Add methods for reading individual RGB values from LED buffers #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamCarlberg
commented
Feb 1, 2024
| * indexed for-loop. | ||
| */ | ||
| @FunctionalInterface | ||
| public interface IndexedColorIterator { |
There was a problem hiding this comment.
This name implies the existence of a non-indexed iterator, but since for-each iterators in the standard library don't include indexes I figured it would be helpful to make it obvious that the index number would also be passed to the function
|
Looks good, just needs C++. |
C++ can already read the individual RGB values. It doesn't need to be changed. |
|
The C++ API uses user-managed arrays of LEDData structs. If a user wants the value of a single channel, they can just read it from their array themselves. |
PeterJohnson
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6332