[cameraserver] Add GetInstance() to all functions #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetInstance() is required to start the event listener that creates the network table entries.
|
This solution seems rather fragile. Is there a better solution? |
|
The right fix is to implement cscore's AddListener() immediate notification, but that's much too invasive of a change to do this year. This fixes the common use cases, but doesn't fix all cases, as e.g. creating a UsbCamera manually before calling any CameraServer functions will still have the issue, but there's an easy workaround--call CameraServer::SetSize() prior to creating any cameras. |
Starlight220
pushed a commit
to Starlight220/allwpilib
that referenced
this pull request
Mar 2, 2023
GetInstance() is required to start the event listener that creates the network table entries. This is a C++ only change; Java uses static's and thus doesn't need this. The right fix is to implement cscore's AddListener() immediate notification, but that's much too invasive of a change to do this year. This fixes the common use cases, but doesn't fix all cases, as e.g. creating a UsbCamera manually before calling any CameraServer functions will still have the issue, but there's an easy workaround--call CameraServer::SetSize() prior to creating any cameras.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetInstance() is required to start the event listener that creates the network table entries.
This is a C++ only change; Java uses static's and thus doesn't need this.