[cpp cmd] BREAKING: Delete UB-causing rvalue variants of CommandPtr methods #4923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzblue
previously requested changes
Jan 10, 2023
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandScheduler.cpp
Outdated
Show resolved
Hide resolved
…duler.cpp Co-authored-by: Ryan Blue <[email protected]>
PeterJohnson
approved these changes
Jan 12, 2023
Starlight220
added a commit
to Starlight220/allwpilib
that referenced
this pull request
Mar 2, 2023
…pilibsuite#4923) Co-authored-by: Ryan Blue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue came to my attention a week ago on Discord.
This PR also rewords the command-already-composed error message to what is already used in Java; the confusing message hindered finding this bug.
I'm aware that we've already in-season and breaking changes shouldn't be done, but on the other hand this is a mistake that is very easy to make and quite difficult to diagnose. This PR does include breaking changes, but they're quite small in scope and make this type of mistake harder to make. Therefore, I think the benefit is worth breaking here.