Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] DigitalCommunication, I2CCommunication: Add tests #4865

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

Starlight220
Copy link
Member

No description provided.

@Starlight220 Starlight220 marked this pull request as ready for review December 29, 2022 16:53
@Starlight220 Starlight220 requested review from a team as code owners December 29, 2022 16:53
@rzblue
Copy link
Member

rzblue commented Dec 29, 2022

Have you tried creating a project from this with the vscode plugin? Just want to make sure it still compiles/works fine when taken out of the allwpilib context- especially if "enable desktop support" is unchecked

@Starlight220
Copy link
Member Author

I'm not sure how to get vscode to pull examples from a dev build.

@sciencewhiz
Copy link
Contributor

publish the allwpilib build and then build the vs code extension and it will pull in the dev build examples/templates.

@sciencewhiz
Copy link
Contributor

the examples test folder doesn't appear to be published

@Starlight220
Copy link
Member Author

That's semi-intentional, and would need vscode changes. We haven't decided that we want those tests in user projects -- keeping them there would fail deploys if the code is changed.

@Starlight220 Starlight220 changed the title [examples] DigitalCommunication: Add tests [examples] DigitalCommunication, I2CCommunication: Add tests Jan 1, 2023
@PeterJohnson PeterJohnson merged commit 79f5651 into wpilibsuite:main Jan 9, 2023
@Starlight220 Starlight220 deleted the dc-test branch January 9, 2023 08:23
Starlight220 added a commit to Starlight220/allwpilib that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants