Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ntcore] Pass pub/sub options as a unified PubSubOptions struct #4794

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

PeterJohnson
Copy link
Member

In Java, PubSubOption is still used for passing options, but this simplifies C++ substantially, as it allows aggregate construction.

PubSubOptions will also be used when adding decoding of metatopics.

In Java, PubSubOption is still used for passing options, but this
simplifies C++ substantially, as it allows aggregate construction.

PubSubOptions will also be used when adding decoding of metatopics.
@PeterJohnson PeterJohnson requested review from a team as code owners December 10, 2022 23:46
@PeterJohnson PeterJohnson merged commit a865f48 into wpilibsuite:main Dec 13, 2022
@PeterJohnson PeterJohnson deleted the nt-pubsuboptions branch December 13, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants