Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more detail on group contents in command group getName() #5250

Open
Nadezaxer opened this issue Apr 4, 2023 · 1 comment · May be fixed by #4735
Open

Include more detail on group contents in command group getName() #5250

Nadezaxer opened this issue Apr 4, 2023 · 1 comment · May be fixed by #4735
Labels
component: command-based WPILib Command Based Library type: fix Iterations on existing features or infrastructure.

Comments

@Nadezaxer
Copy link

Currently most of the compost commands' (parallel, sequential, etc.) getName return just the compost command's name. I would like to see the getName method return more details on what command is internal running. The Repeat Command does exactly what I would like to see for the rest of the compost commands; where it is Repeat(InternalCommandName).


Examples:

  • SequentialCommandGroup: Sequential(CurrentCommand)
  • ParallelCommandGroup: Parallel(CommandA, CommandB, CommandC)
  • ParallelDeadlineGroup: ParallelDeadline(DeadlineCommand, CommandA, CommandB)
@Starlight220
Copy link
Member

The name shouldn't be dynamic, but there's definitely room for improvement - both in the name as well as Sendable representations.

@calcmogul calcmogul changed the title Compost Commands getName() more detail Include more detail on group contents in command group getName() Aug 2, 2023
@calcmogul calcmogul added component: command-based WPILib Command Based Library type: fix Iterations on existing features or infrastructure. labels Aug 2, 2023
@Starlight220 Starlight220 linked a pull request Sep 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: command-based WPILib Command Based Library type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants