Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle creating SimDeviceSim before corresponding SimDevice #5056

Open
PeterJohnson opened this issue Feb 5, 2023 · 0 comments
Open

Handle creating SimDeviceSim before corresponding SimDevice #5056

PeterJohnson opened this issue Feb 5, 2023 · 0 comments
Labels
component: hal Hardware Abstraction Layer os: simulation type: fix Iterations on existing features or infrastructure.
Milestone

Comments

@PeterJohnson
Copy link
Member

Currently this returns an invalid handle. Throwing on non-existent device (added in #5041, reverted in #5053) isn't a great solution as it creates an ordering dependency, but neither is silently creating an useless object. Instead, it would be best if the handle was valid but we did something like print out a warning if the actual SimDevice doesn't exist by the time a function is called on the SimDeviceSim.

@PeterJohnson PeterJohnson added this to the 2024 milestone Feb 5, 2023
@auscompgeek auscompgeek added os: simulation component: hal Hardware Abstraction Layer labels Apr 1, 2023
@calcmogul calcmogul changed the title [hal] Handle creating SimDeviceSim before corresponding SimDevice Handle creating SimDeviceSim before corresponding SimDevice Aug 2, 2023
@calcmogul calcmogul added the type: fix Iterations on existing features or infrastructure. label Aug 2, 2023
@PeterJohnson PeterJohnson modified the milestones: 2024, 2025 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hal Hardware Abstraction Layer os: simulation type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

No branches or pull requests

3 participants