Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish velocity commands from RamseteCommand to NetworkTables #4627

Closed
calcmogul opened this issue Nov 14, 2022 · 5 comments · Fixed by #4822
Closed

Publish velocity commands from RamseteCommand to NetworkTables #4627

calcmogul opened this issue Nov 14, 2022 · 5 comments · Fixed by #4822

Comments

@calcmogul
Copy link
Member

Is your feature request related to a problem? Please describe.
When RamseteCommand doesn't work out of the box, you need to be able to plot the pose setpoint, pose estimate, velocity commands, velocity measurements, and motor voltages to figure out what's going wrong. RamseteCommand has access to the pose setpoint and velocity commands, but doesn't expose them.

Describe the solution you'd like
The data mentioned above should be available on NetworkTables for live plotting with Glass.

@rzblue
Copy link
Member

rzblue commented Nov 14, 2022

How would we want to do this/where should we put the values? We probably don't want to have them published to a static table since you can create multiple RamseteCommands.

We could have the option for the user to select a root table, maybe only publish if they specify that option?

@Starlight220
Copy link
Member

Since RamseteCommand is Sendable (via CommandBase), I think it'd be natural to override initSendable and publish the data there.

@rzblue
Copy link
Member

rzblue commented Nov 14, 2022

The only issue there is that any composition is going to mess that up.

@sciencewhiz
Copy link
Contributor

Is there already something to borrow from the sendable richness PR?

@Starlight220
Copy link
Member

The setpoints can be retrieved using the velocity-accepting lambda ctor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants