Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump faustwp/cli to 0.1.5 #101

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Bump faustwp/cli to 0.1.5 #101

merged 1 commit into from
Nov 22, 2022

Conversation

nickcernis
Copy link
Member

@nickcernis nickcernis commented Nov 22, 2022

So that new FAUST_NO_INTERACTION env vars work when creating Faust.js sites from a blueprint in Local.

Context

The @faustwp/cli package introduced a FAUST_NO_INTERACTION env var in 0.1.5 at wpengine/faustjs#1162. It allows unsupervised installation of Faust without a user prompt to accept/decline telemetry.

The Local Atlas add on runs npm install in this blueprint's directory when the site is first cloned.

Without this version bump to 0.1.5, faustwp/cli 0.1.4 gets installed during blueprint setup. This means the new FAUST_NO_INTERACTION env var is ignored and the node server never gets beyond the telemetry prompt.

So that new FAUST_NO_INTERACTION env vars work when starting sites
from a blueprint in Local.
@nickcernis nickcernis requested a review from a team as a code owner November 22, 2022 10:36
Copy link
Member

@theodesp theodesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@nickcernis nickcernis merged commit a5235bf into main Nov 22, 2022
@nickcernis nickcernis deleted the deps/faustwp-cli branch November 22, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants