Skip to content

Remove content negotiation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

felipeerias
Copy link
Collaborator

This PR removes content negotiation from the spec.

It is more efficient to use content negotiation on the server to select which bundle to send, rather than including several variants in the bundle and having that negotiation happen on the client's side.

Issue: #2

Adapted from WICG/webpackage#618

This change removes content negotiation from the spec.

It is more efficient to use content negotiation on the server to select which
bundle to send, rather than including several variants in the bundle and having
that negotiation happen on the client's side.

Issue: wpack-wg#2

Adapted from WICG/webpackage#618
@felipeerias felipeerias requested a review from jyasskin as a code owner July 5, 2021 02:40
@hayatoito hayatoito self-requested a review July 6, 2021 05:06
Copy link
Collaborator

@hayatoito hayatoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR!

Per the discussion #2, the chromium side is okay to remove content negotiation.

We probably have to change parser's behavior by checking a bundle's version. That should not be a significant issue for us.

We might want to wait for @jyasskin 's approval before merge.

@jyasskin
Copy link
Collaborator

jyasskin commented Jul 20, 2021

Now that the working group has adopted the document, we actually need them to approve significant changes like this one, not me. We can check on this one during the IETF meeting on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants