Skip to content

Conversation

@stevezehngut
Copy link
Contributor

@stevezehngut stevezehngut commented Dec 2, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Critical fix to product types

Does this close any currently open issues?

Fixes #583

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@jasonbahl jasonbahl requested a review from kidunot89 December 7, 2021 20:40
@kidunot89 kidunot89 added the bugfix Implements bugfix label Dec 7, 2021
Copy link
Collaborator

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevezehngut Sorry for my slow review, and thanks for the hard work 🙏🏿

@kidunot89 kidunot89 merged commit d020328 into wp-graphql:develop Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Implements bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ciritcal bug - Product types

2 participants