Handle MySQL commands without deprecation warnings

[ton31337]

With this fix:

% ./vendor/bin/wp db check --path=/tmp/wordpress
mariadb-check: ...

Issue: #271

[ton31337]

Seems that lots of tests are failing due to MySQL connection.

[mrsdizzie]

I'm not sure it is right to silence the warning without addressing it -- the original issue is that right now if you install MariaDB it will create symlinks like:

stat /usr/bin/mysqldump
  File: /usr/bin/mysqldump -> mariadb-dump

and if you run mysqldump it gives a warning mysqldump Deprecated program name. It will be removed in a future release, use mariadb-dump instead

So this code gets rid of the warning temporarily by checking where the link points, but the actual problem the warning is telling us is that mysqldump link will be removed completely in a future release. This code still leaves wp db relying on the existence of a mysqldump link in order to work and it would still break when that link is removed. So silencing the warning seems worse, because it would then stop working without warning at some point in the future.

I think any change should actually address the warning and fix the code to know about MariaDB command names and if we should use those. I haven't looked close enough to see how we should decide that: If wp db should check and know what type of database is in use, or if it should be less clever and just check for the existence of mariadb-dump etc... in the case that mysqldump doesn't exist.

[ton31337]

This code still leaves wp db relying on the existence of a mysqldump link in order to work and it would still break when that link is removed.

IMO, both methods should be combined to solve this issue. I mean following the symlink + handling the real mariadb* commands (which is annoying from MariaDB's perspective, but it is how it is).

On the other side, the current implementation is broken too if the symlink is removed completely by MariaDB.

If wp db should check and know what type of database is in use, or if it should be less clever and just check for the existence of mariadb-dump etc... in the case that mysqldump doesn't exist.

Yes, that's what I had in my head above, either be clever or dumb.

[mrsdizzie]

Thank you for the PR / push to address this. This should be fixed by #275 which will select the proper command based on the current MySQL / MariaDB version