Fix System.MissingMethodException on constructing a row with a string[] #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an exception that is thrown when trying to call the .ConstructRow method for a .db2 file that has an array of strings in its definition such as for the BattlePetEffectProperties.db2 in 9.2.7.45745.
Current code in the added testcase fails with the following exception:
System.MissingMethodException: 'Cannot dynamically create an instance of type 'System.String'. Reason: Uninitialized Strings cannot be created.'After changes the above exception no longer occurs.