Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unix socket support #28

Open
wouterd opened this issue Aug 4, 2014 · 4 comments
Open

Add unix socket support #28

wouterd opened this issue Aug 4, 2014 · 4 comments

Comments

@wouterd
Copy link
Owner

wouterd commented Aug 4, 2014

The plugin currently connects to docker using the rest api.
It would be nice to also have unix socket support.

@Krijger
Copy link
Contributor

Krijger commented Aug 23, 2014

I'm currently working on this, looking good

@Krijger
Copy link
Contributor

Krijger commented Aug 23, 2014

I just got the 'create' and 'start' of containers to work on sockets. WIP, but maybe check it out on https://github.com/Krijger/docker-maven-plugin/tree/28-socket-support

Here is part of my configuration:

<plugin>
            <groupId>net.wouterdanes.docker</groupId>
            <artifactId>docker-maven-plugin</artifactId>
            <version>${docker-maven-version}</version>
            <configuration>
                <providerName>socket</providerName>
            </configuration>
            <executions>
                <execution>
                    <id>start</id>
                    <configuration>
                        <containers>
                            <container>
                                <id>MySQL</id>
                                <image>mysql</image>
                            </container>
                        </containers>
                    </configuration>
                    <goals>
                        <goal>start-containers</goal>
                    </goals>
                </execution>

@wouterd
Copy link
Owner Author

wouterd commented Aug 23, 2014

Making progress, eh?
Looking at your code, have you looked at using current HTTP libs with a transport other than TCP?
That would've been my first guess: take something like HTTPClient or JerseyClient and then override the transport mechanism. That way you don't have to write (parts of) the HTTP protocol.

@Krijger
Copy link
Contributor

Krijger commented Aug 23, 2014

Maybe a good idea - haven't looked at that or found it in my search for
socket communication. Especially if it will take care of the parsing as
well, which I really haven't done yet - it should of course. Would like to
get a working example ASAP though...
Op 23 aug. 2014 20:40 schreef "Wouter Danes" [email protected]:

Making progress, eh?
Looking at your code, have you looked at using current HTTP libs with a
transport other than TCP?
That would've been my first guess: take something like HTTPClient or
JerseyClient and then override the transport mechanism. That way you don't
have to rewrite the HTTP protocol.


Reply to this email directly or view it on GitHub
#28 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants