-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evm: add WormholeCctpTokenMessenger
abstract and optimize CircleIntegration
#48
base: main
Are you sure you want to change the base?
Conversation
da622c5
to
967f0dc
Compare
0c80c47
to
8095770
Compare
Just to confirm, the reasoning for the storage slot layout is because this is going to be an upgrade of an existing deployment? |
Yes exactly. Before the contract laid out the storage without specifying specific slots. But now that I moved some of these too immutables, I did not want the references to unused slots. I guess I could call the unused ones "gap". Which is preferred? |
No I'm happy to keep that as is. I think it's good to be clear that these slots were used before. Although I'd suggest wiping those storage slots to 0 in the initialiser of the new deployment just in case. And then on the next upgrade (the one after this) we could use those slots again. And then add sufficient docstrings/comments to explain what has happened with those slots, are they safe, etc. Happy to diff this change if you would like? |
2e9cc44
to
5ca4dbd
Compare
WormholeCctp
abstract and optimize CircleIntegration
WormholeCctpTokenMessenger
abstract and optimize CircleIntegration
916ad81
to
1709060
Compare
* add WormholeCctpTokenMessenger * inherit above in CircleIntegration * remove updateWormholeFinality (gov) * reorganize * add more forge tests * remove integration tests * add gas snapshot
6f93f93
to
f40b4d0
Compare
NOTE: Commit a59d8a4 was accidentally squashed among other commits.
96ab6b1
to
7599cbe
Compare
PR Summary
WormholeCctpTokenMessenger
abstract contract for integrators that do not want to compose withCircleIntegration
WormholeCctpTokenMessenger
for optimizedCircleIntegration
CircleIntegration
ImprovementsInheriting
WormholeCctp
vs Composing withCircleIntegration
Run
make gas-report
to generate above values. There is slight variance in computed gas numbers due to fuzzed inputs.NOTE: Integration tests are removed in this PR. These will be added back in when we add another network like Solana.