Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: Update JVM build target to 11 #1766

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

tristanvuong2021
Copy link
Contributor

build!: Update JVM build target to 11

@tristanvuong2021 tristanvuong2021 marked this pull request as ready for review August 20, 2024 17:09
@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 merged commit f61e4c7 into main Aug 21, 2024
4 checks passed
@tristanvuong2021 tristanvuong2021 deleted the trristanvuong-update-jvm-build-target-11 branch August 21, 2024 14:31
@SanjayVas
Copy link
Member

Rolled back in #1776

SanjayVas pushed a commit that referenced this pull request Aug 29, 2024
This reverts #1776 to re-apply #1766.

This turned out to not be the cause of the correctness test failure
@TNATALI TNATALI added this to the v0.5.9 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants