fix: Update Kingdom's duchy id config to select fulfillingDuchyId for HMSS

[renjiezh]

No description provided.

[wfa-reviewable]

This change is 

[renjiezh]

Fix #1735

[renjiezh]

Deployment needs to update the content of hmss_protocol_config_config.textproto

[SanjayVas]

The --hmss_protocol_config_config flag was only added in b836fc7, which has never made it into a full release, so we don't need to specifically call it out in 0.5.7 release notes. It's still indeed a breaking change though.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ple13 and @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/CreateMeasurements.kt line 51 at r1 (raw file):

import org.wfanet.measurement.kingdom.deploy.gcloud.spanner.writers.SpannerWriter.TransactionScope

private const val HMSS_MINIMUM_NUMBER_OF_REQUIRED_DUCHIES = 3

nit: this is technically not just the minimum, but also the maximum

Suggestion:

HMSS_DUCHY_COUNT

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/CreateMeasurements.kt line 51 at r1 (raw file):

import org.wfanet.measurement.kingdom.deploy.gcloud.spanner.writers.SpannerWriter.TransactionScope

private const val HMSS_MINIMUM_NUMBER_OF_REQUIRED_DUCHIES = 3

nit: define new constants in companion object. See https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/docs/code-style.md#kotlin

Suggestion:

HMSS_REQUIRED_DUCHIES

[ple13]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/duchy/service/api/v2alpha/RequisitionFulfillmentService.kt line 57 at r1 (raw file):

/** Implementation of `wfa.measurement.api.v2alpha.RequisitionFulfillment` gRPC service. */
class RequisitionFulfillmentService(
  private val duchyId: String,

nit: use externalDuchyId instead of duchyId.

[SanjayVas]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/duchy/service/api/v2alpha/RequisitionFulfillmentService.kt line 57 at r1 (raw file):

Previously, ple13 (Phi) wrote…

nit: use externalDuchyId instead of duchyId.

In public service impls, any ID is assumed to be the external ID. The public service impl doesn't even have access to the internal DB IDs. Those are a private implementation detail of the internal service impl.

[stevenwarejones]

Reviewed 11 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/CreateMeasurements.kt line 476 at r2 (raw file):

  companion object {
    private const val HMSS_DUCHY_COUNT = 3

this feel really ugly to bury this here in a spanner write. I'd prefer it either stay in the protocol config or be a flag passed in or something like that.

[renjiezh]

Reviewable status: 11 of 16 files reviewed, 1 unresolved discussion (waiting on @ple13, @SanjayVas, and @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/CreateMeasurements.kt line 476 at r2 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

this feel really ugly to bury this here in a spanner write. I'd prefer it either stay in the protocol config or be a flag passed in or something like that.

Done.
Good point.

[SanjayVas]

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)

[stevenwarejones]

Reviewed 1 of 13 files at r1, 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

[stevenwarejones]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)