fix: ensure Mill job should process claimed work item #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
7211c81
to
c3a16d5
Compare
renjiezh
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
|
Depends on #1707 |
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
c3a16d5
to
469e002
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
469e002
to
dd352ab
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-hmss
branch
from
5239b46
to
6175965
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
dd352ab
to
3d9d569
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-hmss
branch
from
6175965
to
a0bcac3
Compare
stevenwarejones
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
3d9d569
to
b314730
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-hmss
branch
from
a0bcac3
to
0f5c674
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
b314730
to
2b4b087
Compare
SanjayVas
force-pushed
the
sanjayvas-mill-job-hmss
branch
from
0f5c674
to
ad0bd8d
Compare
This checks that the work item has not changed since it was claimed and that the Mill instance currently holds the lock for the work item.
SanjayVas
force-pushed
the
sanjayvas-mill-job-check-token
branch
from
2b4b087
to
4e031e7
Compare
ple13
pushed a commit
that referenced
this pull request
Aug 16, 2024
This checks that the work item has not changed since it was claimed and that the Mill instance currently holds the lock for the work item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that the work item has not changed since it was claimed and that the Mill instance currently holds the lock for the work item.