Add enabledHmssMeasurementConsumers into kingdom config

[renjiezh]

Also merged two HMSS feature flags.

[wfa-reviewable]

This change is 

[SanjayVas]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @renjiezh)

---

src/main/proto/wfa/measurement/internal/kingdom/protocol_config_config.proto line 47 at r1 (raw file):

  // List of MeasurementConsumer names who force to enable HMSS protocol
  // regardless the feature flags.
  repeated string enabled_measurement_consumers = 3;

This should be a flag next to --enable-hmss rather than in the ProtocolConfig. That way it's obvious how the two flags interact, or why one might see the HMSS protocol used despite --enable-hmss being false.

[renjiezh]

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @SanjayVas)

---

src/main/proto/wfa/measurement/internal/kingdom/protocol_config_config.proto line 47 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

This should be a flag next to --enable-hmss rather than in the ProtocolConfig. That way it's obvious how the two flags interact, or why one might see the HMSS protocol used despite --enable-hmss being false.

I see. It look clearer. In this case, it is set by command line arguments instead of adding these value in config file.
it will be like:

--enable-hmss=false
--enabled_measurement_consumer measurememtConsumers/123abc1
--enabled_measurement_consumer measurememtConsumers/123abc2

The user needs to updates the k8s yml and redeploy it. Does it work better considering origin's practice?

[SanjayVas]

Reviewed all commit messages.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @renjiezh)

---

src/main/proto/wfa/measurement/internal/kingdom/protocol_config_config.proto line 47 at r1 (raw file):

Previously, renjiezh wrote…

I see. It look clearer. In this case, it is set by command line arguments instead of adding these value in config file.
it will be like:

--enable-hmss=false
--enabled_measurement_consumer measurememtConsumers/123abc1
--enabled_measurement_consumer measurememtConsumers/123abc2

The user needs to updates the k8s yml and redeploy it. Does it work better considering origin's practice?

You have to update the K8s objects anyway in order to pick up configmap updates, at least if you're using Kustomize the way we recommend. If you're using non-hashed configmaps, then you at least need to restart your deployments.

[kungfucraig]

Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

---

src/main/proto/wfa/measurement/internal/kingdom/protocol_config_config.proto line 47 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

You have to update the K8s objects anyway in order to pick up configmap updates, at least if you're using Kustomize the way we recommend. If you're using non-hashed configmaps, then you at least need to restart your deployments.

+1 for having this next to the general "enabled" flag. This will be deleted once HMSS is fully launched.

[renjiezh]

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @SanjayVas)

---

src/main/proto/wfa/measurement/internal/kingdom/protocol_config_config.proto line 47 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

+1 for having this next to the general "enabled" flag. This will be deleted once HMSS is fully launched.

Done.

[kungfucraig]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

[kungfucraig]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

[SanjayVas]

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

[stevenwarejones]

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)