Added method for batching search the findAcdpBalanceEntries #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RibeiroAna
force-pushed
the
ribeiroana-select-batch
branch
3 times, most recently
from
5db7bc8
to
f7d969e
Compare
RibeiroAna
force-pushed
the
ribeiroana-select-batch
branch
from
f7d969e
to
f1df928
Compare
added 9 commits
July 19, 2024 15:25
…-of-advertisers/cross-media-measurement into ribeiroana-select-batch
…-of-advertisers/cross-media-measurement into ribeiroana-select-batch
…-of-advertisers/cross-media-measurement into ribeiroana-select-batch
stevenwarejones
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RibeiroAna)
|
Waiting on @uakyol to take a pass since this is for PBM. |
|
@uakyol can you take a look? I need your approval |
uakyol
approved these changes
Jul 29, 2024
uakyol
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
SanjayVas
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
ple13
pushed a commit
that referenced
this pull request
Aug 16, 2024
At Meta we were facing some performance issues when trying to find privacy bucket groups one by one. We created internally some methods to batch the select queries and that helped. We think this should be added to the interface so other EDP implementing the PBM can also create methods to batch their entries. Co-authored-by: RibeiroAna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Meta we were facing some performance issues when trying to find privacy bucket groups one by one. We created internally some methods to batch the select queries and that helped. We think this should be added to the interface so other EDP implementing the PBM can also create methods to batch their entries.