Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ExchangeCheckpoint protobuf message for Kingdom-less panel match #1675

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

robinsons
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@robinsons robinsons marked this pull request as ready for review July 2, 2024 14:28
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the design, I can't remember if this was put in a signedMessage or not, but I think it should be when its shared

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @robinsons)


src/main/proto/wfa/panelmatch/client/internal/exchange_checkpoint.proto line 41 at r1 (raw file):

  google.type.Date exchange_date = 3;

  // Fingerprint of the workflow being executed. The fingerprint is of the

nit: cryptographically secure fingerprint

@robinsons robinsons force-pushed the robinsons-panelmatch-checkpoint branch from 83d05e4 to c67db94 Compare July 3, 2024 17:53
@robinsons robinsons enabled auto-merge (squash) July 3, 2024 17:54
Copy link
Contributor Author

@robinsons robinsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @robinsons)

@robinsons robinsons merged commit 20c48db into main Jul 3, 2024
4 checks passed
@robinsons robinsons deleted the robinsons-panelmatch-checkpoint branch July 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants