Add support for reach only HMSS.

[ple13]

1. EdpSimulator to charge privacy budget for reach-only HMSS.
2. HMSS Mill supports reach-only HMSS.

[wfa-reviewable]

This change is 

[kungfucraig]

Reviewed 2 of 6 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ple13, @renjiezh, @SanjayVas, and @uakyol)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 394 at r2 (raw file):

          CompleteShufflePhaseRequest.NonAggregatorOrder.SECOND
        }
      if (hmss.parameters.hasReachDpParams()) {

Why add the "has" checks?

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 477 at r2 (raw file):

        }
      }
      if (hmss.parameters.hasReachDpParams()) {

Same as above.

---

src/test/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMillTest.kt line 1113 at r2 (raw file):

    val requisitionBlobContext3 =
      RequisitionBlobContext(GLOBAL_ID, REACH_ONLY_REQUISITION_3.externalKey.externalRequisitionId)
    // TODO(@renjiez): Use ShareShuffleSketch from any-sketch-java when it is available..

Use FrequencyVector?

[ple13]

Reviewable status: 10 of 11 files reviewed, 3 unresolved discussions (waiting on @kungfucraig, @renjiezh, @SanjayVas, and @uakyol)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 394 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Why add the "has" checks?

In Herald (

cross-media-measurement/src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/HonestMajorityShareShuffleStarter.kt

Line 167 in 77d12ac

return HonestMajorityShareShuffleKt.ComputationDetailsKt.parameters {

), we do not always set the reach/frequency DP params. The has checks are to make sure that we will only set the fields if they exist.

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 477 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Same as above.

Done.

---

src/test/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMillTest.kt line 1113 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Use FrequencyVector?

Done.

[kungfucraig]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh, @SanjayVas, and @uakyol)

[renjiezh]

Reviewed 2 of 6 files at r1, 8 of 9 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas and @uakyol)

[stevenwarejones]

Reviewed 2 of 6 files at r1, 8 of 9 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas and @uakyol)

[SanjayVas]

Reviewed 2 of 6 files at r1, 8 of 9 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ple13 and @uakyol)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 437 at r3 (raw file):

    val measurementSpec =
      MeasurementSpec.parseFrom(token.computationDetails.kingdomComputation.measurementSpec)
    val result =

nit: explicit types when not obvious. I can't tell from looking at this without an IDE what the type is.

See https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/docs/code-style.md#kotlin

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 461 at r3 (raw file):

  private suspend fun aggregationPhase(token: ComputationToken): ComputationToken {
    val measurementSpec =

It's not safe to parse this before the API version check. It's the API version that tells you what version of the MeasurementSpec message/class to use.

[ple13]

Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @renjiezh, @SanjayVas, @stevenwarejones, and @uakyol)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 437 at r3 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

nit: explicit types when not obvious. I can't tell from looking at this without an IDE what the type is.

See https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/docs/code-style.md#kotlin

Done.

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/shareshuffle/HonestMajorityShareShuffleMill.kt line 461 at r3 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

It's not safe to parse this before the API version check. It's the API version that tells you what version of the MeasurementSpec message/class to use.

Done.

[SanjayVas]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @uakyol)