Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etag support to system ComputationParticipant. #1654

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@SanjayVas SanjayVas requested a review from renjiezh June 7, 2024 23:48
@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-participant-etag branch 3 times, most recently from 97680a6 to 50542a5 Compare June 10, 2024 19:17
Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 30 files at r1, all commit messages.
Reviewable status: 4 of 30 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/KingdomInternalException.kt line 400 at r1 (raw file):

) : KingdomInternalException(ErrorCode.MEASUREMENT_ETAG_MISMATCH, message) {
  override val context
    get() = mapOf("actual_etag" to actualETag, "request_etag" to requestETag)

Is it possible to add the participant State into the context? So that the duchy can skip the rpc call if it is duplicated.

@SanjayVas SanjayVas requested a review from renjiezh June 10, 2024 21:00
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 30 files reviewed, 1 unresolved discussion (waiting on @renjiezh)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/KingdomInternalException.kt line 400 at r1 (raw file):

Previously, renjiezh wrote…

Is it possible to add the participant State into the context? So that the duchy can skip the rpc call if it is duplicated.

The context should just be the variables of the error message. It shouldn't be used to pass resource info. If the caller wants the state, it should do another read.

Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 26 of 30 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas changed the base branch from main to renjiez-common-jvm-85 June 14, 2024 18:15
@SanjayVas
Copy link
Member Author

Depends on #1664

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 25 of 30 files at r1, 2 of 2 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/ETags.kt line 22 at r3 (raw file):

import org.wfanet.measurement.gcloud.common.toInstant

object ETags {

why this duplicate object? that just calls common?

Base automatically changed from renjiez-common-jvm-85 to main June 17, 2024 17:13
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/common/ETags.kt line 22 at r3 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

why this duplicate object? that just calls common?

This version is for com.google.cloud.Timestamp, which is currently only used for Spanner. The top-level common shouldn't have that dependency

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit d5fccad into main Jun 17, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-participant-etag branch June 17, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants