Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add lockfile check to presubmit workflow #265

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

tristanvuong2021
Copy link
Contributor

fix: Add lockfile check to presubmit workflow

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)


.github/workflows/build-test.yml line 31 at r2 (raw file):

    steps:
    - name: Check out revision
      uses: actions/checkout@v3

nit: would you mind switching this and actions/cache to v4 while in here? v3 is deprecated

@tristanvuong2021 tristanvuong2021 requested review from stevenwarejones and removed request for stevenwarejones August 15, 2024 18:11
Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 merged commit a699202 into main Aug 19, 2024
3 checks passed
@tristanvuong2021 tristanvuong2021 deleted the tristanvuong-fix-workflow-to-check-lockfile branch August 19, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants