Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: Upgrade Mockito to v5 #263

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Conversation

tristanvuong2021
Copy link
Contributor

@tristanvuong2021 tristanvuong2021 commented Aug 12, 2024

build!: Upgrade Mockito to v5

The capability to mock final methods is added in v5, which is necessary for testing in some cases. This does, however, add the requirement to target jvm version 11.

BREAKING CHANGE: Targets Java 11

To migrate to this commit, the .bazelrc file needs to include "build --java_language_version=11". If a version of this already exists that targets an older language version, update it to target 11. Otherwise, add the line.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow Conventional Commits. e.g.

chore!: Upgrade Mockito to v5

BREAKING CHANGE: Targets Java 11

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)


BUILD.bazel line 5 at r1 (raw file):

package(default_visibility = ["//visibility:public"])

define_kt_toolchain(

Can this be moved to //build/rules_kotlin?

Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


BUILD.bazel line 5 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Can this be moved to //build/rules_kotlin?

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the first line is the PR title. See https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/3659-kubectl-apply-prune/README.md#kubectl-commands-and-flags

Actually looking at the category descriptions, this would probably be build rather than chore.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 changed the title Upgrade Mockito Upgrade Mockito to V5 Aug 13, 2024
@tristanvuong2021 tristanvuong2021 changed the title Upgrade Mockito to V5 Upgrade Mockito to v5 Aug 13, 2024
Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 changed the title Upgrade Mockito to v5 build!: Upgrade Mockito to v5 Aug 14, 2024
Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

Copy link
Contributor Author

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 1 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 merged commit 880d5c8 into main Aug 14, 2024
3 checks passed
@tristanvuong2021 tristanvuong2021 deleted the tristanvuong-upgrade-mockito branch August 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants