-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: Upgrade Mockito to v5 #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow Conventional Commits. e.g.
chore!: Upgrade Mockito to v5
BREAKING CHANGE: Targets Java 11
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
BUILD.bazel
line 5 at r1 (raw file):
package(default_visibility = ["//visibility:public"]) define_kt_toolchain(
Can this be moved to //build/rules_kotlin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 6 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
BUILD.bazel
line 5 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Can this be moved to //build/rules_kotlin?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the first line is the PR title. See https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/3659-kubectl-apply-prune/README.md#kubectl-commands-and-flags
Actually looking at the category descriptions, this would probably be build
rather than chore
.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
f0192b7
to
e50fb4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 1 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
build!: Upgrade Mockito to v5
The capability to mock final methods is added in v5, which is necessary for testing in some cases. This does, however, add the requirement to target jvm version 11.
BREAKING CHANGE: Targets Java 11
To migrate to this commit, the .bazelrc file needs to include "build --java_language_version=11". If a version of this already exists that targets an older language version, update it to target 11. Otherwise, add the line.