Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShareShuffleSketch. #45

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add ShareShuffleSketch. #45

merged 3 commits into from
Feb 29, 2024

Conversation

renjiezh
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ple13 and @renjiezh)


src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto line 27 at r1 (raw file):

option java_outer_classname = "ShareShuffleSketchProto";

// The data share of HonestMajorityShareShuffle protocol.

Deferring to @kungfucraig on whether this naming makes sense.

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ple13 and @renjiezh)


src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto line 29 at r1 (raw file):

// The data share of HonestMajorityShareShuffle protocol.
message ShareShuffleSketch {
  // A vector of counts.

A vector of count where each count corresponds to the frequency of a single VID.

Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @ple13, and @SanjayVas)


src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto line 29 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

A vector of count where each count corresponds to the frequency of a single VID.

Done.

Copy link
Contributor

@ple13 ple13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @stevenwarejones)

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)


src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto line 31 at r2 (raw file):

  // A vector of count where each count corresponds to the frequency of a single
  // VID.
  repeated uint32 data = 1;

are we planning to try to compress any of this?

Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto line 31 at r2 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

are we planning to try to compress any of this?

For now we are not planning to compress the data. But I appreciate this idea and I will keep it in mind.

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

@renjiezh renjiezh enabled auto-merge (squash) February 29, 2024 22:11
@renjiezh renjiezh enabled auto-merge (squash) February 29, 2024 22:12
@renjiezh renjiezh enabled auto-merge (squash) February 29, 2024 22:12
@renjiezh renjiezh merged commit bcaffae into main Feb 29, 2024
3 checks passed
@renjiezh renjiezh deleted the share_shuffle_sketch branch February 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants