-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShareShuffleSketch. #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ple13 and @renjiezh)
src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto
line 27 at r1 (raw file):
option java_outer_classname = "ShareShuffleSketchProto"; // The data share of HonestMajorityShareShuffle protocol.
Deferring to @kungfucraig on whether this naming makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ple13 and @renjiezh)
src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto
line 29 at r1 (raw file):
// The data share of HonestMajorityShareShuffle protocol. message ShareShuffleSketch { // A vector of counts.
A vector of count where each count corresponds to the frequency of a single VID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @ple13, and @SanjayVas)
src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto
line 29 at r1 (raw file):
Previously, kungfucraig (Craig Wright) wrote…
A vector of count where each count corresponds to the frequency of a single VID.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)
src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto
line 31 at r2 (raw file):
// A vector of count where each count corresponds to the frequency of a single // VID. repeated uint32 data = 1;
are we planning to try to compress any of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
src/main/proto/wfa/any_sketch/share_shuffle_sketch.proto
line 31 at r2 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
are we planning to try to compress any of this?
For now we are not planning to compress the data. But I appreciate this idea and I will keep it in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)
No description provided.