Add .editorconfig and format files
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliu-workos
commented
Oct 27, 2021
.editorconfig
Outdated
| [*.{kt,kts}] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 |
There was a problem hiding this comment.
@marktran gave some feedback around using 2 spaces instead of 4
I lean towards 2 spaces. The old "java" way was 4.
Google's style guide is 2: https://github.com/search?p=3&q=.editorconfig++%5B%2A.%7Bkt%2Ckts%7D%5D+indent_size&type=Code
Looking through Github, there's a mix of 2/4...lots of folks have their editors set to 2 spaces by default but make an exception for java/groovy/kotlin and set it to 4
There was a problem hiding this comment.
I definitely prefer 2, so this is 👍🏻
There was a problem hiding this comment.
I saw in a thread that Pinterest, Square, Trello, Google also use Kotlin and they're 2 space gang.
robframpton
approved these changes
Oct 27, 2021
dliu-workos
force-pushed
the
editorconfig
branch
from
2d1c64a to
69798c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.