Conversation
ofrogon
reviewed
Aug 30, 2023
Co-authored-by: Alexandre Beaudoin <alexandre.beaudoin@gsoft.com>
Co-authored-by: Alexandre Beaudoin <alexandre.beaudoin@gsoft.com>
ofrogon
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to packages
@workleap/swc-configs@workleap/browserslist-configcontains anextendskeyword which is not supported bybrowserslist-rs(see https://github.com/browserslist/browserslist-rs#limitations). The fix has been to introduce abrowserslistToSwcutility function which call the JavaScript version ofbrowserslistand convert the returned browser versions into valid SWC targets.jsc.targetproperty has been removed in favor of providingenv.targets(view the previous change)defineDevConfiganddefineBuildConfig,browsersoption has been renamed totargets.@workleap/typescript-configsmoduleproperty must now be set toNodeNextwhenmoduleResolutionis set toNodeNext. To accomodate this breaking change thecore.tsfilemoduleproperty value is nowNodeNext. The decision has been made to not setmoduleResolutiontoBundlerbecause that would result in the file extensions not being required anymore forimportstatements.@workleap/eslint-plugines2024instead ofes6.Miscellaneous
Chore changes
browserslist-config, eslint-plugin, stylelint-configs
"moduleResolution": "Node"has been added to thetsconfig.jsonfile because usingmodule: "CommonJS"when themoduleResolutionis set toNodeNextis now invalid with TS 5.2."moduleResolution": "Node"is the equivalent of a Node 10 environment, and Node 10 doesn't support theexportsfield in thepackage.jsonfile, thetypesfield has been added to thepackage.jsonfile.browserslist-config, swc-configs, tsup-configs,
tsup7.2 introduced a breaking change that now emits distinct declaration files for CJS and EMS. In response to that change, our projects supporting dual module systems had to update theirpackage.jsonfile to map a specific type declaration file per module system (index.d.ts for CommonJS and index.d.mts for ESM).webpack-configs
Release:
@workleap/eslint-plugin@workleap/swc-configs@workleap/typescript-configs