Restored processors registration that was broken in MediatR 12.1.0+#49
Merged
Anthony Simmon (asimmon) merged 1 commit intomainfrom Jan 12, 2024
Merged
Conversation
...rkleap.Extensions.MediatR.Analyzers.Tests/Workleap.Extensions.MediatR.Analyzers.Tests.csproj
Show resolved
Hide resolved
...xtensions.MediatR.ApplicationInsights/Workleap.Extensions.MediatR.ApplicationInsights.csproj
Show resolved
Hide resolved
Guillaume Caya-Letourneau (Gcaya)
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Context
We planed to leverage MediatR pre and post processors to execute arbitrary code before and after requests are executed.
These processors used to be automatically registered. Developers didn't have to manually register them in the DI services.
In MediatR 12.1.0, the automatic registration was removed, and devs were forced to manually register them in the DI services.
In MediatR 12.2.0, the automatic registration was supposed to be brought back under an option that must be set to true (opt-in), but it's bugged.
More details in this opened PR: LuckyPennySoftware/MediatR#989 (comment)
Changes
Breaking changes
Now that we upgraded to MediatR 2.2.0, there are a few side-effects:
There's nothing we can do about that. There was no need for MediatR to do these upgrades. Usually third-parties dependencies like that are kept to a minimum version.
Additional checks
- [ ] Updated the documentation of the project to reflect the changes