Skip to content

Improved the selectable prefixlengths in dropdown #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wouterhhuisman merged 1 commit into from
Jan 22, 2024
Merged

Improved the selectable prefixlengths in dropdown #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/orchestrator-ui-components/src/components/WfoForms/formFields/SplitPrefix.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,22 @@ export default class SplitPrefix extends React.PureComponent<IProps> {
};

render() {
// IPv4 subnet size should be between /32 and /12
// IPv6 subnet size should be between /128 and /32
const { id, name, subnet, prefixlen, prefixMin, selectedSubnet } =
this.props;
const version = subnet.indexOf(':') === -1 ? 4 : 6;
const max_for_version = version === 4 ? 32 : prefixMin + 11;
const minPrefixLength = version === 4 ? 12 : 32;
const minimalSelectablePrefixLength =
minPrefixLength > prefixMin ? minPrefixLength : prefixMin;
const maximalSelectablePrefixLength =
version === 4 ? 32 : minimalSelectablePrefixLength + 12;

const { desiredPrefixlen } = this.state;
const prefixlengths = range(max_for_version - prefixMin + 1).map(
(x) => prefixMin + x,
);
const prefixlengths = range(
maximalSelectablePrefixLength - minimalSelectablePrefixLength + 1,
).map((x) => minimalSelectablePrefixLength + x);

const length_options: Option<number>[] = prefixlengths.map((pl) => ({
value: pl,
label: pl.toString(),
Expand Down