-
Notifications
You must be signed in to change notification settings - Fork 7
inline edit for description of metadata pages #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cfde3d5
inline edit for description of resourcetypes
wouterhhuisman 166c133
inline edit for description for remaining metadata pages
wouterhhuisman 92ed953
Create strong-experts-act.md
wouterhhuisman 94391b5
Update strong-experts-act.md
wouterhhuisman 54421d9
refactored code to remove duplicated code
wouterhhuisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "storybook": patch | ||
| "@orchestrator-ui/orchestrator-ui-components": patch | ||
| --- | ||
|
|
||
| inline edit for description of metadata pages | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,68 +1,68 @@ | ||
| :root { | ||
wouterhhuisman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| font-family: Inter, system-ui, Avenir, Helvetica, Arial, sans-serif; | ||
| line-height: 1.5; | ||
| font-weight: 400; | ||
| font-family: Inter, system-ui, Avenir, Helvetica, Arial, sans-serif; | ||
| line-height: 1.5; | ||
| font-weight: 400; | ||
|
|
||
| color-scheme: light dark; | ||
| color: rgba(255, 255, 255, 0.87); | ||
| background-color: #242424; | ||
| color-scheme: light dark; | ||
| color: rgba(255, 255, 255, 0.87); | ||
| background-color: #242424; | ||
|
|
||
| font-synthesis: none; | ||
| text-rendering: optimizeLegibility; | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| font-synthesis: none; | ||
| text-rendering: optimizeLegibility; | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| } | ||
|
|
||
| a { | ||
| font-weight: 500; | ||
| color: #646cff; | ||
| text-decoration: inherit; | ||
| font-weight: 500; | ||
| color: #646cff; | ||
| text-decoration: inherit; | ||
| } | ||
| a:hover { | ||
| color: #535bf2; | ||
| color: #535bf2; | ||
| } | ||
|
|
||
| body { | ||
| margin: 0; | ||
| display: flex; | ||
| place-items: center; | ||
| min-width: 320px; | ||
| min-height: 100vh; | ||
| margin: 0; | ||
| display: flex; | ||
| place-items: center; | ||
| min-width: 320px; | ||
| min-height: 100vh; | ||
| } | ||
|
|
||
| h1 { | ||
| font-size: 3.2em; | ||
| line-height: 1.1; | ||
| font-size: 3.2em; | ||
| line-height: 1.1; | ||
| } | ||
|
|
||
| button { | ||
| border-radius: 8px; | ||
| border: 1px solid transparent; | ||
| padding: 0.6em 1.2em; | ||
| font-size: 1em; | ||
| font-weight: 500; | ||
| font-family: inherit; | ||
| background-color: #1a1a1a; | ||
| cursor: pointer; | ||
| transition: border-color 0.25s; | ||
| border-radius: 8px; | ||
| border: 1px solid transparent; | ||
| padding: 0.6em 1.2em; | ||
| font-size: 1em; | ||
| font-weight: 500; | ||
| font-family: inherit; | ||
| background-color: #1a1a1a; | ||
| cursor: pointer; | ||
| transition: border-color 0.25s; | ||
| } | ||
| button:hover { | ||
| border-color: #646cff; | ||
| border-color: #646cff; | ||
| } | ||
| button:focus, | ||
| button:focus-visible { | ||
| outline: 4px auto -webkit-focus-ring-color; | ||
| outline: 4px auto -webkit-focus-ring-color; | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: light) { | ||
| :root { | ||
| color: #213547; | ||
| background-color: #ffffff; | ||
| } | ||
| a:hover { | ||
| color: #747bff; | ||
| } | ||
| button { | ||
| background-color: #f9f9f9; | ||
| } | ||
| :root { | ||
| color: #213547; | ||
| background-color: #ffffff; | ||
| } | ||
| a:hover { | ||
| color: #747bff; | ||
| } | ||
| button { | ||
| background-color: #f9f9f9; | ||
| } | ||
| } | ||
32 changes: 32 additions & 0 deletions
32
...orchestrator-ui-components/src/components/WfoMetadata/WfoProductBlockDescriptionField.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import React, { FC } from 'react'; | ||
|
|
||
| import { useUpdateProductBlockMutation } from '@/rtk/endpoints/metadata/productBlocks'; | ||
|
|
||
| import { WfoInlineEdit } from '../WfoInlineEdit'; | ||
|
|
||
| interface WfoProductBlockDescriptionFieldProps { | ||
| product_block_id: string; | ||
| description: string; | ||
| onlyShowOnHover?: boolean; | ||
| } | ||
|
|
||
| export const WfoProductBlockDescriptionField: FC< | ||
| WfoProductBlockDescriptionFieldProps | ||
| > = ({ product_block_id, description, onlyShowOnHover = true }) => { | ||
| const [updateProductBlock, {}] = useUpdateProductBlockMutation(); | ||
wouterhhuisman marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| return ( | ||
| <div> | ||
| <WfoInlineEdit | ||
| value={description} | ||
| onlyShowOnHover={onlyShowOnHover} | ||
| onSave={(value) => | ||
| updateProductBlock({ | ||
| product_block_id: product_block_id, | ||
| description: value, | ||
| }) | ||
| } | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
32 changes: 32 additions & 0 deletions
32
...ages/orchestrator-ui-components/src/components/WfoMetadata/WfoProductDescriptionField.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import React, { FC } from 'react'; | ||
|
|
||
| import { useUpdateProductMutation } from '@/rtk/endpoints/metadata/products'; | ||
|
|
||
| import { WfoInlineEdit } from '../WfoInlineEdit'; | ||
|
|
||
| interface WfoProductDescriptionFieldProps { | ||
| product_id: string; | ||
| description: string; | ||
| onlyShowOnHover?: boolean; | ||
| } | ||
|
|
||
| export const WfoProductDescriptionField: FC< | ||
| WfoProductDescriptionFieldProps | ||
| > = ({ product_id, description, onlyShowOnHover = true }) => { | ||
| const [updateProduct, {}] = useUpdateProductMutation(); | ||
|
|
||
| return ( | ||
| <div> | ||
| <WfoInlineEdit | ||
| value={description} | ||
| onlyShowOnHover={onlyShowOnHover} | ||
| onSave={(value) => | ||
| updateProduct({ | ||
| product_id: product_id, | ||
| description: value, | ||
| }) | ||
| } | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
wouterhhuisman marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
32 changes: 32 additions & 0 deletions
32
...orchestrator-ui-components/src/components/WfoMetadata/WfoResourceTypeDescriptionField.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import React, { FC } from 'react'; | ||
|
|
||
| import { useUpdateResourceTypeMutation } from '@/rtk/endpoints/metadata/resourceTypes'; | ||
|
|
||
| import { WfoInlineEdit } from '../WfoInlineEdit'; | ||
|
|
||
| interface WfoResourceTypeDescriptionFieldProps { | ||
| resource_type_id: string; | ||
| description: string; | ||
| onlyShowOnHover?: boolean; | ||
| } | ||
|
|
||
| export const WfoResourceTypeDescriptionField: FC< | ||
| WfoResourceTypeDescriptionFieldProps | ||
| > = ({ resource_type_id, description, onlyShowOnHover = true }) => { | ||
| const [updateResourceType, {}] = useUpdateResourceTypeMutation(); | ||
|
|
||
| return ( | ||
| <div> | ||
| <WfoInlineEdit | ||
| value={description} | ||
| onlyShowOnHover={onlyShowOnHover} | ||
| onSave={(value) => | ||
| updateResourceType({ | ||
| resource_type_id: resource_type_id, | ||
| description: value, | ||
| }) | ||
| } | ||
| /> | ||
| </div> | ||
| ); | ||
| }; |
32 changes: 32 additions & 0 deletions
32
...ges/orchestrator-ui-components/src/components/WfoMetadata/WfoWorkflowDescriptionField.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import React, { FC } from 'react'; | ||
|
|
||
| import { useUpdateWorkflowMutation } from '@/rtk/endpoints/metadata/workflows'; | ||
|
|
||
| import { WfoInlineEdit } from '../WfoInlineEdit'; | ||
|
|
||
| interface WfoWorkflowDescriptionFieldProps { | ||
| workflow_id: string; | ||
| description: string; | ||
| onlyShowOnHover?: boolean; | ||
| } | ||
|
|
||
| export const WfoWorkflowDescriptionField: FC< | ||
| WfoWorkflowDescriptionFieldProps | ||
| > = ({ workflow_id, description, onlyShowOnHover = true }) => { | ||
| const [updateWorkflowType, {}] = useUpdateWorkflowMutation(); | ||
|
|
||
| return ( | ||
| <div> | ||
| <WfoInlineEdit | ||
| value={description} | ||
| onlyShowOnHover={onlyShowOnHover} | ||
| onSave={(value) => | ||
| updateWorkflowType({ | ||
| workflow_id: workflow_id, | ||
| description: value, | ||
| }) | ||
| } | ||
| /> | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.