-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inserter - basic support for block addition #88
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
fd47cc0
added createBlockAction and CREATE action type
mzorz 35d3e1c
updated dispatcher mapping for createBlockAction
mzorz 109e3be
added reducer for ActionTypes.BLOCK.CREATE actionType
mzorz f98d844
changed copypaste wording
mzorz 6fcd938
added ToolbarButton.PLUS button handler inserting new object in List …
mzorz 00aa9d3
extracted block placeholder creation to buildEmptyBlock function
mzorz 09102c1
moved emptyBlock helper function to block-builder within /store
mzorz 51981d0
Merge branch 'master' into try/inserter-take1
mzorz de92b5e
removed debugger statements
mzorz abd68f4
using ints for new block ids
mzorz 82c3e7f
modified comment
mzorz 2beaebd
fixed createBlock action to correctly propagate the change
mzorz c6ad773
updated test
mzorz c95ea0b
removed logger call
mzorz 2abdc07
fix importing type as a value
mzorz 7dc1b42
modified signature of createBlockAction( newId, newBlock ) and fixed …
mzorz f4d6e85
fixed flow and lint errors
mzorz 728ef6a
fixed test for block creation
mzorz 57698ed
ditch mocked block-builder in favor of using the actual GB createBloc…
mzorz 4dec244
fixed tests
mzorz bf1dd7f
removed comment
mzorz 5e392d5
Merge pull request #89 from wordpress-mobile/try/inserter-use-create-…
daniloercoli 851d191
Merge branch 'master' into try/inserter-take1
mzorz d2d5247
using new supported core/paragraph block in inserter, and adding focu…
mzorz f34612b
added missing semicolon
mzorz 303f74f
Merge branch 'feature/inserter' into try/inserter-take1
mzorz 6abc253
udpated to latest feature base branch
mzorz c3e8f11
cascading latest changes from master
mzorz 9b97ffa
updated usage of uid in favor of clientId
mzorz d03931c
delete added file by mistake
mzorz 6ad3813
added clientId check in test
mzorz e556378
added block check in test
mzorz a04c5e9
tests: moved registerCoreBlock() to beforeAll()
mzorz 54220f8
removed unused imports
mzorz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, apparently we're passing an already instantiated block to the action so, I wonder if the naming ("createBlock...") is a bit off here. I'd kinda expect to pass some identifier and/or params in order for the reducer to instantiate the block. Not sure which way is the web side of Gutenberg's doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rightly spotted @hypest - as discussed on Slack, this is something I had plans for in a later PR, to take care of bringing this closer to GB 👍
Trackerd in my item list here #58 (comment)