Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.101.0 #6024

Merged
merged 14 commits into from
Aug 3, 2023
Merged

Release 1.101.0 #6024

merged 14 commits into from
Aug 3, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Aug 3, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.101.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes in 1.101.0

Change 1: Remove visual gap in mobile toolbar when a Gallery block is selected

Resolves an issue with removing an extra visual gap in the mobile toolbar.

Change 2: Remove Gallery caption button on mobile

Removes a non-functioning caption button from the mobile Gallery block toolbar. On mobile, the caption can be edited directly via the text input beneath the gallery item, and the caption button is not utilized in the same way it is on web.

Change 3: Fix Gallery block selection when adding media

Updates the Gallery block to mirror the behaviour of other blocks, e.g. the Image block. As a specific example, tapping "Add media" within an empty Gallery block now results in the Gallery block becoming the actively selected block.

Change 4: Upgrade React Native to 0.71.11

Change 5: Upgrade Gradle to 8.2.1 & AGP to 8.1.0

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

Revert "Clone the repo faster in Buildkite (#6008)"
53f5c6d 
This reverts commit f77e859, reversing
changes made to e063b29.
@SiobhyB SiobhyB mentioned this pull request Aug 3, 2023
Merged
This was referenced Aug 3, 2023
Merged
Merged
@SiobhyB SiobhyB marked this pull request as ready for review August 3, 2023 13:22
@geriux geriux self-requested a review August 3, 2023 14:36
geriux
geriux approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@geriux
Copy link
Contributor

geriux commented Aug 3, 2023

@SiobhyB when is time to merge this back to trunk, should we avoid including the revert of #6008? Maybe we can check with @mokagio to see if there's a quick fix that could land separately.

Remove incorrect RELEASE-NOTES entry
d6dc0d0 
The iOS focus loop will be included in 1.100.2. I've updated the RELEASE-NOTES to reflect it won't be a part of of 1.101.0.
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 3, 2023

@geriux, good point, do you think it'd make sense to create the release tag with the revert included, but then restore the change before merging to trunk? I can then add a comment to #6008 to share the issues we came across.

@SiobhyB SiobhyB mentioned this pull request Aug 3, 2023
Merged
2 tasks
@SiobhyB SiobhyB merged commit a79742b into trunk Aug 3, 2023
@SiobhyB SiobhyB deleted the release/1.101.0 branch August 3, 2023 19:50
@derekblank derekblank mentioned this pull request Aug 7, 2023
Closed
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 8, 2023 •
edited
Loading

🟢 Writing Flow (Android)

Build: 23.0-rc-1
Device: Pixel 6 (Android 13)

General

  • TC001 - Paste formatted text copied from website

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 8, 2023 •
edited
Loading

🟢 Unsupported Blocks Tests (Android)

Build: 23.0-rc-1
Device: Pixel 6 (Android 13)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 8, 2023 •
edited
Loading

🟢 Recent Changes (Android)

Build: 23.0-rc-1
Device: Pixel 6 (Android 13)

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 8, 2023 •
edited
Loading

🟢 Recent Changes (Android)

Build: 23.0-rc-1
Device: Pixel 6 (Android 13)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • Active icon gets product color - TC001
  • Social icon forwarding to the link - TC002

@mokagio
Copy link
Contributor

mokagio commented Aug 9, 2023

@SiobhyB @geriux

do you think it'd make sense to create the release tag with the revert included, but then restore the change before merging to trunk? I can then add a comment to #6008 to share the issues we came across.

FWIW, that's the approach I would have taken, too.

I shall try to address the issues with that revert today/tomorrow 🙏

@derekblank
Copy link
Contributor

derekblank commented Aug 9, 2023 •
edited
Loading

🟢 Writing Flow (iOS)

Build: pr21240-d0525d9
Device: iPhone SE (iOS 16.6)

General

  • TC001 - Paste formatted text copied from website

Rich Text Format

  • TC007 - Test format detection under the cursor
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading

@derekblank
Copy link
Contributor

derekblank commented Aug 9, 2023 •
edited
Loading

🟢 Unsupported Blocks Tests (iOS)

Build: pr21240-d0525d9
Device: iPhone SE (iOS 16.6)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@derekblank
Copy link
Contributor

derekblank commented Aug 9, 2023 •
edited
Loading

🟢 Recent Changes (iOS)

Build: pr21240-d0525d9
Device: iPhone SE (iOS 16.6)

@derekblank
Copy link
Contributor

derekblank commented Aug 9, 2023 •
edited
Loading

🟢 Functionality Tests: Test Suite 2 (iOS)

Build: pr21240-d0525d9
Device: iPhone SE (iOS 16.6)

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - Deep nesting is possible (verify iOS does not crash) - TC001
  • Group - Check if Group placeholder is visible for the unselected state - TC002
  • Group - Check if Group placeholder is render in nested structure - TC003 Note: test cases may need updating after recent UX changes to block outlines
  • Group - Nested block have proper border styling - TC004 Note: test cases may need updating after recent UX changes to block outlines
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC005

Buttons-1

  • Buttons block - Button's wrapper grows properly - TC019
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC002
  • Buttons block - Wrapping Buttons - TC003

Button-2

  • Buttons block - Buttons alignment options - TC004
  • Buttons block - Settings: Open in new tab - TC007
  • Buttons block - Settings: Link rel - TC008

Button-3

  • Buttons block - Settings: Link URL - TC006
  • Buttons block - Settings: Remove link - TC010
  • Buttons block - Settings: Synchronize with button options - TC009

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Drag and Drop Blocks - 1

  • Drag and Drop Blocks - Drag block to the top of the content - TC001
  • Drag and Drop Blocks - Drag block to the bottom of the content - TC002

VideoPress - 2

  • VideoPress block - Player - TC003
  • VideoPress block - Private video - TC005
  • VideoPress block - Upload limit for Free users - TC006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SiobhyB @geriux @mokagio @derekblank