-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Bump react-native-gesture-handler
to version 2.3.2
#4895
[RNMobile] Bump react-native-gesture-handler
to version 2.3.2
#4895
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
"version": "2.4.1-wp-1", | ||
"version": "2.4.1-wp-2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we forgot to update the version of Reanimated after merging the drag & drop functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked what we included in version wp-2
and it was just a fix for Android (reference), so this change will have no impact on iOS 😅 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This worked as expected, I was able to build de demo app and the main apps locally. Do we need to update the bundles with these changes?
Yep, good catch! I'll generate the bundle and test it again, thanks for the tip 🙇 ! |
…eact-native-gesture-handler-2.3.2 # Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map
Related PRs
react-native-gesture-handler
to version2.3.2
WordPress/gutenberg#41337 by @fluiddotreact-native-gesture-handler
to version2.3.2
WordPress-Android#16645react-native-gesture-handler
to version2.3.2
WordPress-iOS#18742Description
This PR is generated by
version-toolkit
to downstream the changes forgutenberg
submodule.