Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Bump react-native-gesture-handler to version 2.3.2 #4895

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented May 25, 2022

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 25, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-assigned this May 25, 2022
@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label May 25, 2022
@fluiddot fluiddot added this to the 1.77.0 milestone May 25, 2022
@fluiddot fluiddot requested a review from geriux May 25, 2022 16:44
"version": "2.4.1-wp-1",
"version": "2.4.1-wp-2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we forgot to update the version of Reanimated after merging the drag & drop functionality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked what we included in version wp-2 and it was just a fix for Android (reference), so this change will have no impact on iOS 😅 .

@SiobhyB SiobhyB modified the milestones: 1.77.0, 1.78.0 May 27, 2022
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This worked as expected, I was able to build de demo app and the main apps locally. Do we need to update the bundles with these changes?

@fluiddot
Copy link
Contributor

LGTM! This worked as expected, I was able to build de demo app and the main apps locally. Do we need to update the bundles with these changes?

Yep, good catch! I'll generate the bundle and test it again, thanks for the tip 🙇 !

@fluiddot fluiddot enabled auto-merge May 27, 2022 15:32
@fluiddot fluiddot merged commit dbb191b into trunk May 27, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/rnmobile/update/react-native-gesture-handler-2.3.2 branch May 27, 2022 16:00
@fluiddot fluiddot mentioned this pull request Jun 10, 2022
4 tasks
@fluiddot fluiddot modified the milestones: 1.79.0 (20.2), 1.78.0 (20.1) Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants