Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable child block settings to be hidden via parent block #4225

Merged
merged 7 commits into from
Nov 15, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Nov 10, 2021

Partial fix for #4190 (note, this PR won't hide the image's caption, only the settings toggle)

To test: Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions. The Gutenberg PR could also be tested with Automattic/jetpack#21694 checked out on the Jetpack side.


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB self-assigned this Nov 10, 2021
@SiobhyB SiobhyB added InnerBlocks Tiled Gallery block Issues with this label will automatically appear on the project's board labels Nov 10, 2021
@SiobhyB SiobhyB marked this pull request as ready for review November 10, 2021 16:40
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guarani guarani self-requested a review November 11, 2021 18:49
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 11, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB merged commit 8323c11 into develop Nov 15, 2021
@SiobhyB SiobhyB deleted the try/hide-child-block-controls branch November 15, 2021 17:53
@SiobhyB SiobhyB restored the try/hide-child-block-controls branch November 16, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InnerBlocks Tiled Gallery block Issues with this label will automatically appear on the project's board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants