Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Introduce Context Constants to Native #4099

Closed

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Oct 11, 2021

Gutenberg: WordPress/gutenberg#35510

With this PR, the idea of introducing context constants, as initially suggested here, is built upon to meet the needs of the apps. Further background and details can be found in the Gutenberg PR, which will act as the 'single source of truth' in terms of updates and testing instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB changed the title [RNMobile] Introduce "Context Constants" For Use with Inner Blocks [RNMobile] Indicate When Contexts Are Intended for Use with Inner Blocks and Native Oct 11, 2021
@SiobhyB SiobhyB requested a review from geriux October 11, 2021 17:21
@SiobhyB SiobhyB marked this pull request as ready for review October 11, 2021 17:21
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 17, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB changed the title [RNMobile] Indicate When Contexts Are Intended for Use with Inner Blocks and Native [RNMobile] Introduce Context Constants to Native Oct 29, 2021
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 22, 2021

Closing per WordPress/gutenberg#35510 (comment).

@SiobhyB SiobhyB closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant