Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for deleting all text on the More block resets it to the default text #363

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

daniloercoli
Copy link
Contributor

This PR fixes #359 by making sure to only use the default text once, during init of the block.
(The web side does the same).

GB side companion PR: WordPress/gutenberg#12821

Steps to test:

  • Tap on a Read More block
  • Delete all the text
  • It should stay empty

Test 2:

  • Add a new Read More block
  • The text should be "Read more"
  • Delete all the text
  • It should stay empty

Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@daniloercoli daniloercoli merged commit 5cfe37c into master Dec 13, 2018
@daniloercoli daniloercoli deleted the issue/359-Deleting-text-more-block branch December 13, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants