Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss keyboard when non-textual block is selected #341

Merged

Conversation

daniloercoli
Copy link
Contributor

This PR fixes #308 by making sure that to call blur on the textual field that lost the focus.

React Native Aztec Wrapper PR is here:wordpress-mobile/react-native-aztec#93

GB side PR: WordPress/gutenberg#12765

Steps to repro:

  • Tap on a para block
  • Tap on the page break block
  • The block holder should be visible on the page break block, and the keyboard dismissed
  • Repeat the steps above by tapping on any of the TextInput "block", and then tap on another kind of block --> the keyboard should be visible only when the focus is on a TextInput field.

Note: The caret is still visible (and blinking) in the TextInput "powered" block that lost the focus. We will fix this in another PR.

Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 remember to update the hashes once Gutenberg-side PR gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants