Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block validation errors #310

Merged
merged 9 commits into from
Dec 4, 2018
Merged

Fix block validation errors #310

merged 9 commits into from
Dec 4, 2018

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Dec 3, 2018

Requires WordPress/gutenberg#12552

Fix "Block validation failed for core/paragraph... " errors when trying the demo post content from gutenberg.

For this we remove the babel transform react-native-classname-to-style which would cause unexpected result when saving blocks and thus validation errors.

This PR also removes some unused dependencies and others that are already provided by @wordpress/babel-preset-default.

Lastly, it updates the initial-html.js and appends the whole content of the gutenberg demo post which can be found here https://wordpress.org/gutenberg/

@@ -39,6 +39,9 @@
<PROJECT_ROOT>/node_modules/fbjs/.*
<PROJECT_ROOT>/node_modules/graphql/.*
<PROJECT_ROOT>/node_modules/prettier/.*
<PROJECT_ROOT>/node_modules/jsx-to-string/.*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like those are necessary sometimes, let's just add those

@pinarol pinarol self-requested a review December 4, 2018 09:28
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Tested with both with iOS example app and with this post on WP-iOS side, it used to display lots of validation errors now it doesn't.

@Tug Tug merged commit f3ce0a4 into master Dec 4, 2018
@Tug Tug deleted the fix/validation-errors branch December 4, 2018 09:46
@Tug Tug mentioned this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants