-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make block holder and toolbar look nicer #286
Conversation
This replaces the icons with dashicons, tweaks the layout to be closer to the designs, and removes the unused settings button.
Adding @iamthomasbishop. |
After talking to Thomas, I still have to:
|
This imports a color palette taken from calypso instead of the Gutenberg one
This needs WordPress/gutenberg#12403 to be merged first |
We're skipping WordPress/gutenberg#12403 for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved :)
|
||
import styles from './style.scss'; | ||
|
||
export default class InlineToolbarButton extends React.Component<PropsType> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @koke, did you maybe consider using ToolbarButton e.g.<ToolbarButton label={ __( 'Undo' ) } icon="undo" isDisabled={ ! hasUndo } onClick={ undo } />
?
As it's the same as what you have created here?
Note: This needs WordPress/gutenberg#12403 to be merged first
Some changes to make the block holder look better:
@iamthomasbishop I know your mockups use Gridicons, but we still don't have those available, and dashicons are already quite an improvement over emoji 😉. Also, I used
$light-gray-500
for the block borders, but I'm not sure if it's the right one, I think your mockups looked more blue than this