Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mobile code for changes in color settings/attributes #2082

Merged
merged 9 commits into from
Mar 31, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 30, 2020

Gutenberg PR: WordPress/gutenberg#21257

To test:

  • Start the demo app
  • Make sure post open
  • Copy blocks from the web where custom colors are set
  • For example paragraph blocks:
<!-- wp:paragraph {"style":{"color":{"text":"#9bc2d3"}}} -->
<p style="--wp--color--text:#9bc2d3" class="has-text-color">text</p>
<!-- /wp:paragraph -->

Check that after switching from HTML to visual the settings on the block are kept.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the Web breakage Caused by incompatible changes on Gutenberg web label Mar 30, 2020
@SergioEstevao SergioEstevao added this to the 1.25 milestone Mar 30, 2020
@SergioEstevao SergioEstevao merged commit cdbcb86 into develop Mar 31, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_color_breakage_issues branch March 31, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants