Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional alignment of focus and selection logic with the web's #1076

Merged
merged 20 commits into from
Jun 8, 2019
Merged

Additional alignment of focus and selection logic with the web's #1076

merged 20 commits into from
Jun 8, 2019

Commits on Jun 5, 2019

  1. Update GB hash: focus, selection logic closer to web's

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    9f05179 View commit details
    Browse the repository at this point in the history

  2. Closer to web's focus and selection logic

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    592b7ca View commit details
    Browse the repository at this point in the history

  3. Pop the keyboard in the next frame 

    For better coordination with animations. This way the RichText does get
focus properly when for example a new paragraph block is added.
    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    3fd7950 View commit details
    Browse the repository at this point in the history

  4. Remove unused imports

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    9d8668b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into issue/1029-keyb-on-focus

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    7e14e31 View commit details
    Browse the repository at this point in the history

  6. Let the contentSizeChange onLayout happen immediately

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    fb795e0 View commit details
    Browse the repository at this point in the history

  7. Focus the EditText's Rect on focus request

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    46fab6c View commit details
    Browse the repository at this point in the history

  8. Re-instate delays :(

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    03b573b View commit details
    Browse the repository at this point in the history

  9. Request caret's line to be visible, not the whole view 

    That way, the view doesn't jump around when merging blocks.
    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    1bbe89e View commit details
    Browse the repository at this point in the history

  10. Just schedule the onContentSizeChange for the next frame 

    No need for fixed delay, at least when testing this on a Pixel 2XL.
    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    b6261f6 View commit details
    Browse the repository at this point in the history

  11. Small delay for requestRectangleOnScreen is enough

    @hypest
    hypest committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    bb31ebd View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. Code cleanup

    @hypest
    hypest committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    0ae0eb9 View commit details
    Browse the repository at this point in the history

  2. Ensure not null when the call will actually happen

    @hypest
    hypest committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    3b39c97 View commit details
    Browse the repository at this point in the history

  3. Update GB hash

    @hypest
    hypest committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    fd48b46 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into issue/1029-keyb-on-focus

    @hypest
    hypest committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    272cec6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into issue/1029-keyb-on-focus

    @hypest
    hypest committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    5fc5a84 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. Update GB hash

    @hypest
    hypest committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    56d1fa1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into issue/1029-keyb-on-focus

    @hypest
    hypest committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    c3df109 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into issue/1029-keyb-on-focus

    @hypest
    hypest committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    536cf46 View commit details
    Browse the repository at this point in the history

  4. Update to the merged GB hash

    @hypest
    hypest committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    7f1dabe View commit details
    Browse the repository at this point in the history