Unsupported Block

[diegoreymendez]

Description:

This PR implements the unsupported block for blocks we don't offer support for.

Fixes #50.

Details:

This PR introduces a new block type to display all the blocks we don't support. Adding support for a block happens through regular registration of the block type in Gutenberg.

Next steps: introduce this new block type as the native version of the freeform block.

Known issues / limitations:

After the changes submitted by @koke in
#127, I could no longer retrieve the original block name to display in visual mode.

This should be fine though, as unsupported blocks could be changing once this is merged: WordPress/gutenberg#8274

Testing:

• Load the standard post content.
• Switch to HTML mode and make sure the block contents are properly maintained.

[etoledom]

After giving it a try, I noticed that it's breaking because getBlockType() fails if it's called with a block name that is not registered and returns undefined. Then it tries to access attributes from that undefined BlockType.

So it's failing when it tries to access blockType.attributes, not block.attributes

At this line it return undefined: serializer.js:259

At this line it try to access attributes:serializer.js:139

I'm not sure what is the best way to fixing this. A try catch avoid the crash but it feels like a regression on behavior:

try {
    return serialize( [ block ] ) + '\n\n';
} catch (error) {
    return block.attributes.content + '\n\n';
}

[etoledom]

I tested an alternative strategy to show the unsupported block UI, based on the conversation we had in slack. It's described here.

[diegoreymendez]

Ready for review.

[koke]

Wouldn’t this always be “Gmobile/unsupported” now?

[diegoreymendez]

Yeppers. I can just remove it if it feels redundant, although I left it in cos otherwise the block feels a bit empty at this time.

Let me know which way you prefer it.

[koke]

Since the other line already says unsupported, I think we can remove it for now

[koke]

Other than the title, this is looking great. The tests are failing on travis though

[koke]

I've fixed the conflicts with master and the tests to get this ready for today's demo. It also turned out that with the latest changes, the block manager didn't need any special case handling for the unsupported block, so that was simplified as well when resolving the conflict: 1a2bfc0

Merging when green