This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Decouple PluginDirectoryServiceRemote from Alamofire
#725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mokagio
changed the title
PluginDirectoryServiceRemote from Alamofire
mokagio
approved these changes
Feb 16, 2024
| ### Breaking Changes | ||
|
|
||
| _None._ | ||
| - Decouple `PluginDirectoryServiceRemote` from Alamofire. [#725] |
There was a problem hiding this comment.
Suggested change
| - Decouple `PluginDirectoryServiceRemote` from Alamofire. [#725] | |
| - Decouple `PluginDirectoryServiceRemote` from Alamofire. [#725] | |
| - Remove `Endpoint`. [#725] |
Endpoint might have been unused, but it was still a public type. Do you think it would be worth to track it in the changelog?
There was a problem hiding this comment.
Sure thing. Added in dce3798.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PluginDirectoryServiceRemotesends HTTP requests toapi.wordpress.org, which we don't have a dedicated API client for. I usedURLSessiondirectly, instead of the customizedURLSession.performfunction, because the extra error handling implemented in theperformfunction is useless inPluginDirectoryServiceRemote.The
Endpointabstraction is removed from this PR, becausePluginDirectoryServiceRemote—the only type that implementsEndpointprotocol—no longer uses it.Testing Details
See updated and added unit tests.
CHANGELOG.mdif necessary.