Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in ImageDownloader #23690

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 23, 2024

This is a potential fix for this crash in iOS 18 betas. I assume, based on the new signature of the withTaskCancellationHandler method that the crash has something to do with isolation, so I moved it to a context with no isolation whatsoever, so hopefully it fixes it.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 25.4.1 milestone Oct 23, 2024
@kean kean requested a review from crazytonyli October 23, 2024 22:25
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.4.1. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23690-123bd42
Version25.4.1
Bundle IDcom.jetpack.alpha
Commit123bd42
App Center Buildjetpack-installable-builds #9888
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23690-123bd42
Version25.4.1
Bundle IDorg.wordpress.alpha
Commit123bd42
App Center BuildWPiOS - One-Offs #10846
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

self.task = task
}

func getData(subscriptionID: UUID) async throws -> Data {
try await withTaskCancellationHandler {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now called with no isolation, so hopefully it will skip the part of the runtime that crashes on iOS 18 betas.

@kean kean merged commit 435bcfa into release/25.4.1 Oct 24, 2024
26 checks passed
@kean kean deleted the fix/image-downloader-crash branch October 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants