Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Sidebar FF and WPSplitViewController with related code #23663

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Remove Sidebar FF and WPSplitViewController with related code #23663

merged 8 commits into from
Oct 8, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 7, 2024

Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the iPad label Oct 7, 2024
@kean kean added this to the 25.5 milestone Oct 7, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

kean
kean commented Oct 7, 2024
View reviewed changes
WordPress/WordPressTest/MySiteViewModelTests.swift
splitViewControllerIsHorizontallyCompact: $1,
isSplitViewEnabled: $2
)
expect(section).to(equal(.siteMenu), description: "Expected .siteMenu, got \(section). Jetpack features \($0), split VC \($1), split view \($2)")
Copy link
Contributor Author

@kean kean Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were 120 lines of tests for a pure function with 3 lines, so I decided it was not worth keeping it.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 7, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23663-b423687
Version25.4
Bundle IDorg.wordpress.alpha
Commitb423687
App Center BuildWPiOS - One-Offs #10798
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 7, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23663-b423687
Version25.4
Bundle IDcom.jetpack.alpha
Commitb423687
App Center Buildjetpack-installable-builds #9840
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean requested a review from crazytonyli October 7, 2024 14:58
@kean kean added this pull request to the merge queue Oct 7, 2024
@kean kean removed this pull request from the merge queue due to a manual request Oct 7, 2024
@kean kean enabled auto-merge October 8, 2024 02:11
@kean kean added this pull request to the merge queue Oct 8, 2024
Merged via the queue into trunk with commit faf0c8b Oct 8, 2024
24 checks passed
@kean kean deleted the task/remove-sidebar-ff branch October 8, 2024 02:45
crazytonyli added a commit that referenced this pull request Oct 15, 2024
@crazytonyli
Resolve merge conflicts: Remove sidebar FF
1929de8 
The feature flag was removed on trunk: #23663
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2024
@wpmobilebot @jkmassel
@iangmaia @mokagio @crazytonyli @dcalhoun @kean @oguzkocer
Merge release/25.4 into trunk (#23673)
ebfd142 
* Bump version number

* Update draft release notes for 25.4.

* Update draft release notes for 25.4.

* Release Notes: add new section for next version (25.5)

* Update strings for localization

* Shave a few bytes off all our icons

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

* Remove alpha channel from WordPress light icon (Any Appearance)

This was done to address an iTMS rejection:

  Asset validation failed (90717) Invalid large app icon.
  The large app icon in the asset catalog in “WordPress.app” can’t be transparent or contain an alpha channel.
  For details, visit: https://developer.apple.com/design/human-interface-guidelines/app-icons.

See https://buildkite.com/automattic/wordpress-ios/builds/24053#019234f2-8086-4160-904a-328283175b3b

This was done via Preview.app: Export... > PNG unticking the "Alpha"
channel.

* Upload Fastlane to handle occasional ASC upload issue

* Update app translations – `Localizable.strings`

* Bump version number

* Bump version number

* Stop handling WordPress.com links in the WordPress app (#23653)

* Stop handling WordPress.com links in the WordPress app

* Address a build failure in the tests because of unhandled `XCTSkip`

---------

Co-authored-by: Gio Lodi <[email protected]>

* feat: Synchronize content with GutenbergKit (#23631)

* Merge release/25.4 into trunk (#23628)

* Bump version number

* Update draft release notes for 25.4.

* Update draft release notes for 25.4.

* Release Notes: add new section for next version (25.5)

* Update strings for localization

* feat: Persist GutenbergKit changes

Ensure post changes are not lost.

* fix: Persist changes if either post title or content changes

The previous conditional erroneously ignored changes unless both values
changed.

* build: Update GutenbergKit ref

* fix: Improve empty editor content check

As noted in the code comment, this value lags behind reality. A race
condition existed in production builds cause inaccurate values. This was
removed to instead rely upon the existing `editorHasContent`
implementation found in the `PostEditor` class.

* build: Update GutenbergKit ref

* build: Update GutenbergKit ref

* build: Update GutenbergKit ref

* Update GutenbergKit ref

* Update GutenbergKit ref

---------

Co-authored-by: WordPress Mobile Bot Account <[email protected]>
Co-authored-by: Gerardo <[email protected]>
Co-authored-by: Jeremy Massel <[email protected]>

* Fix an issue with comment selection state disappearing (#23658)

* Disable Reader anouncemnets (#23655)

* Fix an issue with Me header view alignment (#23647)

* Add Gutenberg Experimental Editor Switch (#23660)

* Add TipKit for Sidebar (#23648)

* Enable TipKit FF (#23661)

* Fix crash in TipKit (#23664)

* Update strings for localization

* Update app translations – `Localizable.strings`

* Bump version number

* Merge 25.4 release notes to `release/25.4` (#23672)

* Add editorialized release notes for version

* Update metadata strings

* Update metadata strings

---------

Co-authored-by: Automattic Release Bot <[email protected]>

* Remove ios_current_branch_is_hotfix from finalize_release

* Add options param to finalize_release lane

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

* Add missing FeatureFlag.sidebar

* Resolve merge conflicts: Remove sidebar FF

The feature flag was removed on trunk: #23663

* Resolve merge conflicts: Remove duplicated code

The code was alrady merged into trunk: #23665

---------

Co-authored-by: Jeremy Massel <[email protected]>
Co-authored-by: Ian Maia <[email protected]>
Co-authored-by: Gio Lodi <[email protected]>
Co-authored-by: Tony Li <[email protected]>
Co-authored-by: David Calhoun <[email protected]>
Co-authored-by: Gerardo <[email protected]>
Co-authored-by: Alex Grebenyuk <[email protected]>
Co-authored-by: Oguz Kocer <[email protected]>
Co-authored-by: Oguz Kocer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees
No one assigned
Labels
iPad
Projects
None yet
Milestone
25.5
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @dangermattic @wpmobilebot @crazytonyli