Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Remove Keyboard Aware Flatlist #20262

Merged
merged 2 commits into from
Apr 10, 2023
Merged

[Gutenberg] Remove Keyboard Aware Flatlist #20262

merged 2 commits into from
Apr 10, 2023

Conversation

geriux
Copy link
Member

@geriux geriux commented Mar 6, 2023 •
edited
Loading

Related PRs:

To test:

Regression Notes

  1. Potential unintended areas of impact
    Block editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tests in Gutenberg Mobile

  3. What automated tests I added (or what prevented me from doing so)
    Rely on tests in Gutenberg Mobile

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Mar 6, 2023
Merged
Merged
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 6, 2023 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20262-b615d94 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 6, 2023 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20262-1e23918 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@geriux geriux force-pushed the gutenberg/remove-keyboard-aware-flatlist branch from 1b4db7d to 1637443 Compare March 10, 2023 13:50
@geriux geriux added this to the 22.0 milestone Mar 10, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 10, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20262-a9f36ba
Version22.1
Bundle IDorg.wordpress.alpha
Commita9f36ba
App Center BuildWPiOS - One-Offs #5442
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 10, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20262-a9f36ba
Version22.1
Bundle IDcom.jetpack.alpha
Commita9f36ba
App Center Buildjetpack-installable-builds #4471
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux geriux force-pushed the gutenberg/remove-keyboard-aware-flatlist branch from 719ec11 to 76a47f5 Compare March 16, 2023 13:34
@mokagio
Copy link
Contributor

mokagio commented Mar 20, 2023

I'll move the milestone to 22.1 because I'm about to start the 22.0 code freeze and this is still a draft. Feel free to revert if necessary.

@mokagio mokagio modified the milestones: 22.0, 22.1 Mar 20, 2023
@geriux geriux force-pushed the gutenberg/remove-keyboard-aware-flatlist branch from 76a47f5 to 2da28ff Compare March 23, 2023 12:36
@geriux geriux marked this pull request as ready for review March 28, 2023 17:32
@geriux geriux requested a review from fluiddot March 29, 2023 06:56
@geriux geriux removed this from the 22.1 milestone Mar 30, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 31, 2023 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@geriux geriux force-pushed the gutenberg/remove-keyboard-aware-flatlist branch from 7e8bb7d to 567705b Compare April 3, 2023 15:54
fluiddot
fluiddot approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#48791 (review).

NOTE: We might consider adding this change to the release notes as it's user-facing.

@geriux geriux force-pushed the gutenberg/remove-keyboard-aware-flatlist branch from d51fbae to a9f36ba Compare April 10, 2023 13:44
@geriux geriux added this to the 22.2 milestone Apr 10, 2023
@geriux
Copy link
Member Author

geriux commented Apr 10, 2023

NOTE: We might consider adding this change to the release notes as it's user-facing.

Definitely! I've added it to the Gutenberg mobile PR, I'll make sure we update the main apps release notes on the next editor release 👍

@geriux geriux merged commit 2d72752 into trunk Apr 10, 2023
@geriux geriux deleted the gutenberg/remove-keyboard-aware-flatlist branch April 10, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.2
Development

Successfully merging this pull request may close these issues.
4 participants
@geriux @wpmobilebot @mokagio @fluiddot