Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dagger to 2.42 #16883

Merged

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Jul 7, 2022

We updated some of our libraries Dagger version to 2.42 as part of AGP 7.2.1 update in #16878. We'd like to avoid Gradle resolving our dependency versions to a different version from the declared one, so we are also updating WPAndroid's Dagger version.

Here are the release notes for Dagger 2.42: https://github.com/google/dagger/releases/tag/dagger-2.42

The only breaking change listed would result in a compile time error and technically this update was smoke tested by me and @ParaskP7 in #16878 because as listed by @wpmobilebot's comment, Dagger was updated to 2.42 due to our libraries already being updated.

To test:

Smoke test the app

Regression Notes

  1. Potential unintended areas of impact
    Dagger updates should be limited to compile time, but sometimes transitive dependency updates happen as part of it, so hard to limit its scope.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Our CI stack and smoke testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer added this to the 20.3 milestone Jul 7, 2022
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

-+--- com.google.dagger:dagger-android-support:2.41 -> 2.42
++--- com.google.dagger:dagger-android-support:2.42
-\--- com.google.dagger:hilt-android:2.41
-     +--- com.google.dagger:dagger:2.41 -> 2.42 (*)
-     +--- com.google.dagger:dagger-lint-aar:2.41 -> 2.42
-     +--- com.google.dagger:hilt-core:2.41
-     |    +--- com.google.dagger:dagger:2.41 -> 2.42 (*)
-     |    +--- com.google.code.findbugs:jsr305:3.0.2
-     |    \--- javax.inject:javax.inject:1
-     +--- com.google.code.findbugs:jsr305:3.0.2
-     +--- androidx.activity:activity:1.3.1 (*)
-     +--- androidx.annotation:annotation:1.2.0
-     +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-     +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-     +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
-     +--- androidx.savedstate:savedstate:1.1.0 (*)
-     +--- javax.inject:javax.inject:1
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.32 -> 1.6.10 (*)
+\--- com.google.dagger:hilt-android:2.42
+     +--- com.google.dagger:dagger:2.42 (*)
+     +--- com.google.dagger:dagger-lint-aar:2.42
+     +--- com.google.dagger:hilt-core:2.42
+     |    +--- com.google.dagger:dagger:2.42 (*)
+     |    +--- com.google.code.findbugs:jsr305:3.0.2
+     |    \--- javax.inject:javax.inject:1
+     +--- com.google.code.findbugs:jsr305:3.0.2
+     +--- androidx.activity:activity:1.3.1 (*)
+     +--- androidx.annotation:annotation:1.2.0
+     +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+     +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
+     +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+     +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
+     +--- androidx.savedstate:savedstate:1.1.0 (*)
+     +--- javax.inject:javax.inject:1
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)

Please review and act accordingly

@oguzkocer oguzkocer marked this pull request as ready for review July 7, 2022 15:28
@oguzkocer oguzkocer requested a review from ParaskP7 July 7, 2022 15:28
@ParaskP7 ParaskP7 self-assigned this Jul 7, 2022
@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16883-1c9dc4d.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16883-1c9dc4d.apk), or scanning this QR code:

Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @oguzkocer !

I reviewed and smoked tested the app again, everything LGTM, it is again a 👍 from my side and thank you so much for doing this update! 💯

@oguzkocer oguzkocer merged commit 155b660 into update-dependencies-to-agp-7.2.1-versions Jul 7, 2022
@oguzkocer oguzkocer deleted the update-dagger-to-2.42 branch July 7, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants