Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Design Revamp] Reduce recommended design thumbnail sizes #16747

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Jun 15, 2022

Fixes #16743

Before After
Screenshot_20220615_100225 Screenshot_20220615_100240

To test:

  1. Start the Site Creation flow
  2. Navigate to the Site Design screen
  3. Expect the thumbnails in the recommended section to match the size and quality of the other thumbnails

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis added this to the 20.1 ❄️ milestone Jun 15, 2022
@antonis antonis requested a review from a team June 15, 2022 07:06
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16747-78fee08.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16747-78fee08.apk), or scanning this QR code:

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and works as described. I tested this with several "intents" as well as with skipping the intent screen, and confirmed it is working well. I also tested the page picker and there are no regressions there.

Thanks for the adjustment Antonis!

@antonis
Copy link
Contributor Author

antonis commented Jun 15, 2022

Thank you for the quick review @mkevins 🙇

@antonis antonis merged commit 88744f5 into release/20.1 Jun 15, 2022
@antonis antonis deleted the task/site-design-recommended-thumbnail-size branch June 15, 2022 09:13
@AliSoftware
Copy link
Contributor

This has now been shipped as part of the WPAndroid/JPAndroid 20.1-rc-2 beta 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants