This repository was archived by the owner on Apr 7, 2026. It is now read-only.
forked from NVIDIA/NemoClaw
-
Notifications
You must be signed in to change notification settings - Fork 0
sync: rebase on upstream (2026-03-27) #8
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6ae809a
fix: improve gateway lifecycle recovery (#953)
kjw3 f0f53e4
fix: swap hard/soft ulimit settings in start script (#951)
epwilkins 7596dab
chore: add cyclomatic complexity lint rule (#875)
cv 7970b7a
docs: add host-side config and state file locations to README (#903)
WuKongAI-CMU bbdc3cb
chore: add tsconfig.cli.json, root execa, TS coverage ratchet (#913)
cv 6d44def
fix: use CONNECT tunnel for WebSocket endpoints in Discord/Slack pres…
BenediktSchackenberg 5c269c1
fix: standardize Node.js minimum version to 22.16 (#840)
cv a87c151
Merge remote-tracking branch 'upstream/main'
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -213,15 +213,17 @@ spin() { | |
|
|
||
| command_exists() { command -v "$1" &>/dev/null; } | ||
|
|
||
| MIN_NODE_MAJOR=20 | ||
| MIN_NODE_VERSION="22.16.0" | ||
| MIN_NPM_MAJOR=10 | ||
| RECOMMENDED_NODE_MAJOR=22 | ||
| RUNTIME_REQUIREMENT_MSG="NemoClaw requires Node.js >=${MIN_NODE_MAJOR} and npm >=${MIN_NPM_MAJOR} (recommended Node.js ${RECOMMENDED_NODE_MAJOR})." | ||
| RUNTIME_REQUIREMENT_MSG="NemoClaw requires Node.js >=${MIN_NODE_VERSION} and npm >=${MIN_NPM_MAJOR}." | ||
|
Comment on lines
+216
to
+218
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This now breaks repo-checkout installs on machines that already have an older Node.js.
Suggested alignment with the curl-pipe installer install_nodejs() {
- if command_exists node; then
- info "Node.js found: $(node --version)"
- return
- fi
+ local node_version="" npm_version="" npm_major=""
+ if command_exists node; then
+ node_version="$(node --version 2>/dev/null || true)"
+ npm_version="$(npm --version 2>/dev/null || true)"
+ npm_major="$(version_major "$npm_version")"
+ info "Node.js found: ${node_version:-unknown}"
+ if version_gte "${node_version#v}" "$MIN_NODE_VERSION" \
+ && [[ "$npm_major" =~ ^[0-9]+$ ]] \
+ && (( npm_major >= MIN_NPM_MAJOR )); then
+ return
+ fi
+ info "Upgrading runtime to satisfy ${RUNTIME_REQUIREMENT_MSG}"
+ fi
- info "Node.js not found — installing via nvm…"
+ info "Installing Node.js via nvm…"Also applies to: 305-306 🤖 Prompt for AI Agents |
||
| NEMOCLAW_SHIM_DIR="${HOME}/.local/bin" | ||
| ORIGINAL_PATH="${PATH:-}" | ||
|
|
||
| # Compare two semver strings (major.minor.patch). Returns 0 if $1 >= $2. | ||
| # Rejects prerelease suffixes (e.g. "22.16.0-rc.1") to avoid arithmetic errors. | ||
| version_gte() { | ||
| [[ "$1" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]] || return 1 | ||
| [[ "$2" =~ ^[0-9]+(\.[0-9]+){0,2}$ ]] || return 1 | ||
| local -a a b | ||
| IFS=. read -ra a <<<"$1" | ||
| IFS=. read -ra b <<<"$2" | ||
|
|
@@ -300,7 +302,7 @@ ensure_supported_runtime() { | |
| [[ "$node_major" =~ ^[0-9]+$ ]] || error "Could not determine Node.js version from '${node_version}'. ${RUNTIME_REQUIREMENT_MSG}" | ||
| [[ "$npm_major" =~ ^[0-9]+$ ]] || error "Could not determine npm version from '${npm_version}'. ${RUNTIME_REQUIREMENT_MSG}" | ||
|
|
||
| if ((node_major < MIN_NODE_MAJOR || npm_major < MIN_NPM_MAJOR)); then | ||
| if ! version_gte "${node_version#v}" "$MIN_NODE_VERSION" || ((npm_major < MIN_NPM_MAJOR)); then | ||
| error "Unsupported runtime detected: Node.js ${node_version:-unknown}, npm ${npm_version:-unknown}. ${RUNTIME_REQUIREMENT_MSG} Upgrade Node.js and rerun the installer." | ||
| fi | ||
|
|
||
|
|
@@ -344,9 +346,9 @@ install_nodejs() { | |
| spin "Installing nvm..." bash "$nvm_tmp" | ||
| rm -f "$nvm_tmp" | ||
| ensure_nvm_loaded | ||
| spin "Installing Node.js ${RECOMMENDED_NODE_MAJOR}..." bash -c ". \"$NVM_DIR/nvm.sh\" && nvm install ${RECOMMENDED_NODE_MAJOR} --no-progress" | ||
| spin "Installing Node.js 22..." bash -c ". \"$NVM_DIR/nvm.sh\" && nvm install 22 --no-progress" | ||
| ensure_nvm_loaded | ||
| nvm use "${RECOMMENDED_NODE_MAJOR}" --silent | ||
| nvm use 22 --silent | ||
| info "Node.js installed: $(node --version)" | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Unprovisioned /data home
🐞 Bug⛯ ReliabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools